Fix of BstPreviewLayout #11343
Closed
Fix of BstPreviewLayout #11343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| BibEntry testEntry = new BibEntry(StandardEntryType.InProceedings) | ||
| .withCitationKey("DBLP:conf/iscas/SadeghifarWG14") | ||
| // .withField(StandardField.AUTHOR, "Mohammad Reza Sadeghifar and J. Jacob Wikner and Oscar Gustafsson") | ||
| //.withField(StandardField.TITLE, "Linear programming design of semi-digital {FIR} filter and {\\(\\Sigma\\)}{\\(\\Delta\\)} modulator for {VDSL2} transmitter") |
There was a problem hiding this comment.
🚫 [reviewdog] reported by reviewdog 🐶
Comment text should start with space.
| // .withField(StandardField.TIMESTAMP, "Sat, 05 Sep 2020 18:07:30 +0200") | ||
| // .withField(new UnknownField("biburl"), "https://dblp.org/rec/conf/iscas/SadeghifarWG14.bib") | ||
| // .withField(new UnknownField("bibsource"), "dblp computer science bibliography, https://dblp.org"); | ||
| ; |
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.NoWhitespaceBeforeCheck> reported by reviewdog 🐶
';' is preceded with whitespace.
| // .withField(StandardField.TIMESTAMP, "Sat, 05 Sep 2020 18:07:30 +0200") | ||
| // .withField(new UnknownField("biburl"), "https://dblp.org/rec/conf/iscas/SadeghifarWG14.bib") | ||
| // .withField(new UnknownField("bibsource"), "dblp computer science bibliography, https://dblp.org"); | ||
| ; |
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.SeparatorWrapCheck> reported by reviewdog 🐶
';' should be on the previous line.
|
The build of this PR is available at https://builds.jabref.org/pull/11343/merge. |
|
To reduce the number of open PRs I will cose this due to inactivity |
|
Ported to koppor#698 |
|
I deleted the branch, too - to reduce the number of branches 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11338
Open points
.body().text()and not for complete HTMLNBSPappears when~is rendered. Strange.Some things need to be fixed upstream: davemckain/snuggletex#7
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)