Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline code in EntryEditor #11379

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Streamline code in EntryEditor #11379

merged 3 commits into from
Jun 17, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 17, 2024

In the context of another PR, I needed to work with the EntryEditor. I moved the refactorings out to a separate PR.

  • Introduce interface OffersPreview
  • Merge two lists of tabs
  • Introduce method
  • Rename variables

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Streamline code in EntryEditor
3de60c6 
- Introduce interface OffersPreview
- Merge two lists of tabs
- Introduce method
- Rename variables
@koppor koppor added the type: code-quality Issues related to code or architecture decisions label Jun 17, 2024
calixtus
calixtus previously approved these changes Jun 17, 2024
View reviewed changes
calixtus
calixtus previously approved these changes Jun 17, 2024
View reviewed changes
@koppor koppor enabled auto-merge June 17, 2024 09:40
@koppor koppor added this pull request to the merge queue Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit a2bd254 Jun 17, 2024
21 checks passed
@koppor koppor deleted the improve-entry-editor branch June 17, 2024 09:57
@koppor koppor mentioned this pull request Jun 17, 2024
Merged
6 tasks
@LoayGhreeb LoayGhreeb mentioned this pull request Jul 17, 2024
Merged
6 tasks
@alexandre-cremieux alexandre-cremieux mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @calixtus