Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search result mapping use UIDs instead of hashcodes of BibDatabaseContext #11402

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Search result mapping use UIDs instead of hashcodes of BibDatabaseContext #11402

merged 1 commit into from
Jun 21, 2024

Conversation

LoayGhreeb
Copy link
Member

Follow-up to #11400
Replace mapping of the BibDatabaseContext to use UIDs, fixing the issue of search results being 0 after updating an entry.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@LoayGhreeb LoayGhreeb requested a review from koppor June 20, 2024 16:57
@koppor koppor added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 6f3cc2f Jun 21, 2024
21 checks passed
@koppor koppor deleted the SearchResultSize branch June 21, 2024 07:28
Siedlerchr added a commit that referenced this pull request Jun 22, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixMedlineImporterK…
1b6532c 
…eywword

* upstream/main:
  Fix dependendency issues with commons logging (#11403)
  New Crowdin updates (#11411)
  Fix search result mapping use UIDs instead of hashcodes (#11402)
  New translations jabref_en.properties (Russian) (#11404)

# Conflicts:
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoayGhreeb @koppor