Fix architecture gui/logic #11729
Fix architecture gui/logic #11729
Conversation
Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
koppor
added
dev: code-quality
# Conflicts: # src/main/java/org/jabref/gui/LibraryTab.java
Co-authored-by: Christoph <siedlerkiller@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Also: - Move openAiChat from AiService (logic) to GroupTree (gui)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
# Conflicts: # src/main/java/org/jabref/gui/ai/components/privacynotice/PrivacyNoticeComponent.java
# Conflicts: # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java
|
Server(Test) still has a dependency on gui prefs |
…xportFormatTestOnlyRequiredFields.xml
…xportFormatTestAllFields.xml
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
Tested locally, seems to work fine so far |
This prepares #110
This is based on #11728 - thus, the first commits are doubled. With some "git magic" they, don't appear in the diff.
Contributes to https://github.com/JabRef/jabref-issue-melting-pot/issues/440
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)