Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetcher tests #11737

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Fix fetcher tests #11737

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8064cbe
Add volume information
subhramit Sep 9, 2024
02ed0a8
Add pages
subhramit Sep 9, 2024
8153752
Fix OpenAccessDOITest
subhramit Sep 9, 2024
883e82a
Revert openaccesssdoifetcher result
subhramit Sep 9, 2024
f6abb13
Change test openAccess article
subhramit Sep 9, 2024
1bae6c8
remove .pdf extension from expected arg
subhramit Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/java/org/jabref/logic/importer/fetcher/OpenAccessDoiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ void setUp() {

@Test
void findByDOI() throws IOException {
entry.setField(StandardField.DOI, "10.1038/nature12373");
assertEquals(Optional.of(new URL("https://dash.harvard.edu/bitstream/1/12285462/1/Nanometer-Scale%20Thermometry.pdf")), finder.findFullText(entry));
entry.setField(StandardField.DOI, "10.1186/s12993-024-00248-9");
assertEquals(Optional.of(new URL("https://behavioralandbrainfunctions.biomedcentral.com/counter/pdf/10.1186/s12993-024-00248-9.pdf")), finder.findFullText(entry));
subhramit marked this conversation as resolved.
Show resolved Hide resolved
}

@Test
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/org/jabref/logic/importer/fetcher/TitleFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ void setUp() {
.withField(StandardField.BOOKTITLE, "2009 35th Euromicro Conference on Software Engineering and Advanced Applications")
.withField(StandardField.PUBLISHER, "IEEE")
.withField(StandardField.TITLE, "BPELscript: A Simplified Script Syntax for WS-BPEL 2.0")
.withField(StandardField.VOLUME, "5331")
.withField(StandardField.YEAR, "2009")
.withField(StandardField.MONTH, "#aug#")
.withField(StandardField.PAGES, "39--46")
.withField(StandardField.DOI, "10.1109/seaa.2009.21");
}

Expand Down
Loading