Fix search test NPE #11749
Fix search test NPE #11749
Conversation
| @@ -315,6 +315,11 @@ public void close() { | |||
| HeadlessExecutorService.INSTANCE.execute(this::closeIndex); | |||
| } | |||
|
|
|||
| @Override | |||
| public void closeAndWait() { | |||
| HeadlessExecutorService.INSTANCE.executeAndWait(this::closeIndex); | |||
There was a problem hiding this comment.
Can we pass this dependency in the constructor as well?
There was a problem hiding this comment.
Can you check this commit 81a30ff (#11749)? added a boolean parameter to the constructor.
There was a problem hiding this comment.
Yeah, sorry, I did not clarfiy. I meant the Executor Service, that would partially also improve the test siutation
There was a problem hiding this comment.
TL;DR: Refactor DefaultLinkedFilesIndexer NOT to depend on HeadlessExecutorService.INSTANCE, but to have an ExecutorService passed using the constructor.
--> follow-up PR
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
| @@ -315,6 +315,11 @@ public void close() { | |||
| HeadlessExecutorService.INSTANCE.execute(this::closeIndex); | |||
| } | |||
|
|
|||
| @Override | |||
| public void closeAndWait() { | |||
| HeadlessExecutorService.INSTANCE.executeAndWait(this::closeIndex); | |||
There was a problem hiding this comment.
TL;DR: Refactor DefaultLinkedFilesIndexer NOT to depend on HeadlessExecutorService.INSTANCE, but to have an ExecutorService passed using the constructor.
--> follow-up PR
Search tests sometimes throw NullPointerException (example: https://github.com/JabRef/jabref/actions/runs/10759644260/job/29836573460).
This issue occurs because multiple tests for the same library share the same index path. The index is closed in a background thread, which may lead to subsequent tests accessing the same index before the previous test closing index finishes.
Although the
org.jabref.gui.util.CurrentThreadTaskExecutoris used to run background tasks sequentially for tests, a different task executor (org.jabref.logic.util.HeadlessExecutorService#INSTANCE) is used for closing the index (due to LoayGhreeb#6).@TempDirfor the index path.closeAndWaitto wait until the task is finished. Using@TempDironly didn't resolve the issue because the next test could start, and@TempDirwould be removed before the closing task finished.Follow-up to #11542.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/527.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)