Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tags field focus #11792

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix tags field focus #11792

merged 1 commit into from
Sep 20, 2024

Conversation

LoayGhreeb
Copy link
Collaborator

Closes #11177

  • Clicking anywhere in the tags field will now correctly request focus.
  • The border color of the field changes when it is focused.

image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@LoayGhreeb LoayGhreeb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 19, 2024
Siedlerchr
Siedlerchr approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works fine

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit ec62ec0 Sep 20, 2024
29 of 30 checks passed
@Siedlerchr Siedlerchr deleted the fix-keywordsField branch September 20, 2024 15:52
Siedlerchr added a commit that referenced this pull request Sep 20, 2024
@Siedlerchr
Merge branch 'fixArxivHtmlImport' of github.com:JabRef/jabref into fi…
058b376 
…xArxivHtmlImport

* 'fixArxivHtmlImport' of github.com:JabRef/jabref:
  Fix focus for keywords and crossref fields (#11792)
  Fix ai chat not on fx thread (#11796)
  [AI] Add more uses statements (#11788)
  Update djl api dependency (#11787)
  Improve pdf content parser for DOIs (#11782)
  minor refactor to JabRefDialogService (#11767)
  Add more OS-dependent context to panel freeze dev documentation. (#11781)
@tobiasdiez
Copy link
Member

Awesome! Thanks for the fix ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
keywords status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding keywords for new entries only possible when clicking on the top left corner of the field
3 participants
@LoayGhreeb @tobiasdiez @Siedlerchr