Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new URI API #11824

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Migrate to new URI API #11824

merged 4 commits into from
Sep 24, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 24, 2024

Applies https://docs.openrewrite.org/recipes/java/migrate/net/urlconstructorstourirecipes

This reduces compilation warnings.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the type: code-quality Issues related to code or architecture decisions label Sep 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

@Siedlerchr
Copy link
Member

seems like it just didn't clean up the imports

Siedlerchr
Siedlerchr previously approved these changes Sep 24, 2024
@Siedlerchr
Copy link
Member

still some errros

(java:2496): dbind-WARNING **: 10:50:50.477: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files

Task :test
org.jabref.logic.net.URLUtilTest

Test isURLshouldRejectInvalidURL() FAILED

java.lang.IllegalArgumentException: URI is not absolute

Test isURLshouldRejectEmbeddedURL() FAILED

java.lang.IllegalArgumentException: Illegal character in scheme name at index 4: dblp computer science bibliography, http://dblp.org/

Copy link
Contributor

github-actions bot commented Sep 24, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 759ecac Sep 24, 2024
26 of 27 checks passed
@Siedlerchr Siedlerchr deleted the rewrite-url branch September 24, 2024 13:04
@koppor koppor mentioned this pull request Sep 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants