-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new URI API #11824
Migrate to new URI API #11824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
seems like it just didn't clean up the imports |
still some errros (java:2496): dbind-WARNING **: 10:50:50.477: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
Test isURLshouldRejectInvalidURL() FAILED java.lang.IllegalArgumentException: URI is not absolute Test isURLshouldRejectEmbeddedURL() FAILED java.lang.IllegalArgumentException: Illegal character in scheme name at index 4: dblp computer science bibliography, http://dblp.org/ |
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Applies https://docs.openrewrite.org/recipes/java/migrate/net/urlconstructorstourirecipes
This reduces compilation warnings.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)