Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto rename files feature fix for #11316 #12443

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wtfjjking
Copy link

@wtfjjking wtfjjking commented Feb 2, 2025

Added a new option [ ] Auto rename files if entry changes under Preferences -> Linked files -> Linked file name conventions, with the default value set to false. When this option is enabled, JabRef will automatically rename files if the filename matches the defined naming pattern.

Users requested that JabRef automatically rename files when entry data is changed, provided the filename matches the defined naming pattern. This feature improves file management automation and reduces the need for manual intervention.

refs #11316

Screenshot 2025-02-02 at 11 18 28

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Jiewu (jack deng) Deng added 4 commits February 1, 2025 15:45
- Add new boolean property for automatic file renaming
- Add getter and setter methods
- Update constructor to include new property
- Add AUTO_RENAME_FILES_ON_CHANGE constant
- Update FilePreferences initialization with new property
- Add property change listener for persistence"
- Add string for checkbox label
- Add string for tooltip text
- Add checkbox to LinkedFilesTab.fxml
- Add property binding in LinkedFilesTabViewModel
- Add tooltip for better user guidance"
@wtfjjking
Copy link
Author

i have only done the ui part, haven't done the logic part yet

@subhramit
Copy link
Member

i have only done the ui part, haven't done the logic part yet

Marking the PR as draft. You can mark it ready to review when done.

@subhramit subhramit marked this pull request as draft February 2, 2025 20:52
…Linked files"/>

2.Relocated the "Auto rename files" option:
Previously located above the file directory section
Now moved below the "Linked file name conventions" section
@wtfjjking
Copy link
Author

I change the data also changing the name generated the defined pattern
JabRef should rename the file, too
hello may i ask what exactly the task mean, is it mean that i link a file to an entry, and then i change the file name in the optional fields, then the file name itself also changed, but currently there is no filename in the optional fields, so I should add one, and then implement the logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants