Skip to content

Switch from zulu to corretto #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koppor merged 7 commits into from
Aug 25, 2025
Merged

Switch from zulu to corretto #13749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
164ac12
Switch from zulu to correto
koppor Aug 25, 2025
650d58f
Update Java from 24.0.1 to 24.0.2
koppor Aug 25, 2025
7448478
Update setup-java to v5
koppor Aug 25, 2025
c8939b4
More general version
koppor Aug 25, 2025
85d0acf
Revert "More general version"
koppor Aug 25, 2025
06bf696
Fix typo
koppor Aug 25, 2025
8ce671a
More general version
koppor Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ jobs:
id: gitversion
uses: gittools/actions/gitversion/execute@v3.2.1
- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: '24'
distribution: 'corretto'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
id: gitversion
uses: gittools/actions/gitversion/execute@v3.2.1
- name: Setup JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: '24'
distribution: 'corretto'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-openrewrite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
GH_TOKEN: ${{secrets.GH_TOKEN_JABREF_MACHINE_PR_APPROVE}}

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
Copy link
Member

@Siedlerchr Siedlerchr Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the version downgrade here!

Copy link
Member Author

@koppor koppor Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you read actions/setup-java#474?

Copy link
Member Author

@koppor koppor Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And #13749 (comment)

Corretto does not work with 24.0.2.

Copy link
Member Author

@koppor koppor Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust setup-java to fetch the latest version (as promised in their README.md).

Eventually (in the English sense), we need to work on switching back to Temurin! https://github.com/JabRef/jabref-issue-melting-pot/issues/1041

Copy link
Member

@Siedlerchr Siedlerchr Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, was not aware of this. Seems to work Downloading Java 24.0.2+12.1 (Corretto) from https://corretto.aws/downloads/resources/24.0.2.12.1/amazon-corretto-24.0.2.12.1-macosx-x64.tar.gz ...

distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Generate JBang cache key
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests-code-fetchers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ jobs:
submodules: 'true'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Run fetcher tests
Expand Down
60 changes: 30 additions & 30 deletions .github/workflows/tests-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ jobs:
submodules: 'true'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Run checkstyle reporter
uses: dbelyaev/action-checkstyle@master
with:
Expand Down Expand Up @@ -84,10 +84,10 @@ jobs:
submodules: 'true'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Generate JBang cache key
Expand Down Expand Up @@ -118,10 +118,10 @@ jobs:
submodules: 'true'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Generate JBang cache key
Expand Down Expand Up @@ -235,10 +235,10 @@ jobs:
- name: Checkout source
uses: actions/checkout@v5
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Generate JBang cache key
Expand Down Expand Up @@ -270,10 +270,10 @@ jobs:
submodules: 'true'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Generate JBang cache key
id: cache-key
shell: bash
Expand Down Expand Up @@ -318,10 +318,10 @@ jobs:
submodules: 'true'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Generate JBang cache key
Expand Down Expand Up @@ -367,10 +367,10 @@ jobs:
submodules: 'true'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Generate JBang cache key
Expand Down Expand Up @@ -405,10 +405,10 @@ jobs:
submodules: 'false'
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Generate JBang cache key
id: cache-key
shell: bash
Expand Down Expand Up @@ -466,10 +466,10 @@ jobs:
show-progress: 'false'
- name: Set up JDK
if: github.ref == 'refs/heads/main'
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- name: Generate JBang cache key
Expand Down Expand Up @@ -511,10 +511,10 @@ jobs:
with:
show-progress: 'false'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: 24.0.1
distribution: 'zulu'
java-version: 24
distribution: 'corretto'
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
- run: ./gradlew traceRequirements
Expand Down