Fix: No exception if file is not within a git repository #13839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
koppor
added
the
status: ready-for-review
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
changed the title
koppor
changed the title
koppor
changed the title
koppor
changed the title
calixtus
approved these changes
Sep 8, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
Comment on lines
+53
to
+54
| @Inject | ||
| private GitHandlerRegistry gitHandlerRegistry; |
There was a problem hiding this comment.
Field injection should be avoided in favor of constructor injection to ensure proper initialization and make dependencies explicit. This also improves testability and makes the class immutable.
| private TaskExecutor taskExecutor; | ||
|
|
||
| @Inject | ||
| private GitHandlerRegistry gitHandlerRegistry; |
There was a problem hiding this comment.
The field should be marked as final since it's injected in the constructor and never reassigned, following the principles of immutability from Effective Java.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)