Add support for transliterated citation keys #13893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I expect that I chose some wrong naming or placement |
Siedlerchr
reviewed
Sep 13, 2025
jablib/src/main/java/org/jabref/logic/bibtex/BibtexStandard.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Sep 13, 2025
jablib/src/test/java/org/jabref/logic/util/strings/TransliterationTest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Sorry, forgot a bit about this PR |
Member
|
It would be nice to have this finished, seems like you just need to adjust the mocks/options in the test? |
Siedlerchr
reviewed
Sep 22, 2025
jablib/src/main/java/org/jabref/logic/citationkeypattern/CitationKeyPatternPreferences.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Sep 22, 2025
jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java
Outdated
Show resolved
Hide resolved
Member
Author
|
on my way
…On Mon, Sep 22, 2025 at 2:58 PM Christoph ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java
<#13893 (comment)>:
> @@ -649,6 +650,7 @@ public JabRefCliPreferences() {
defaults.put(USE_OWNER, Boolean.FALSE);
defaults.put(OVERWRITE_OWNER, Boolean.FALSE);
+ defaults.put(TRANSLITERATE_FIELDS, Boolean.TRUE);
I would make this false by default
—
Reply to this email directly, view it on GitHub
<#13893 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADD5VEUXPUISO77QI3AT4E33T7P7BAVCNFSM6AAAAACGN3KAJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJSGI2DENRZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jablib/src/main/java/org/jabref/logic/citationkeypattern/CitationKeyPatternPreferences.java
Outdated
Show resolved
Hide resolved
jablib/src/main/java/org/jabref/logic/citationkeypattern/CitationKeyPatternPreferences.java
Outdated
Show resolved
Hide resolved
jablib/src/main/java/org/jabref/logic/citationkeypattern/CitationKeyPatternPreferences.java
Outdated
Show resolved
Hide resolved
jablib/src/main/java/org/jabref/logic/citationkeypattern/CitationKeyGenerator.java
Show resolved
Hide resolved
| } | ||
|
|
||
| private static String buildTransliteratorConfig() { | ||
| StringBuilder pattern = new StringBuilder(); |
There was a problem hiding this comment.
Using StringBuilder for simple string concatenation can be replaced with StringJoiner for better readability and maintainability.
jablib/src/main/java/org/jabref/logic/util/strings/Transliteration.java
Outdated
Show resolved
Hide resolved
jablib/src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java
Show resolved
Hide resolved
…elds" + change tests
Siedlerchr
requested changes
Nov 12, 2025
.../src/main/resources/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTab.fxml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
status: changes-required
Member
Author
|
I will fix everything, just this stupid "connection timeout" |
github-actions
bot
removed
the
status: changes-required
InAnYan
added
the
status: ready-for-review
Siedlerchr
approved these changes
Nov 15, 2025
Member
Siedlerchr
left a comment
Siedlerchr
left a comment
There was a problem hiding this comment.
thx for the quick follow up!
Siedlerchr
added a commit
that referenced
this pull request
Nov 15, 2025
…ersions/org.glassfish.jersey.core-jersey-server-4.0.0 * upstream/main: (31 commits) Adds a 'regenerate' button to AI chat tab (#12191) (#14191) Chore(deps): Bump jablib/src/main/resources/csl-styles (#14323) Update dependency com.konghq:unirest-modules-gson to v4.6.0 (#14322) Convert fixed-value ComboBoxes to SearchableComboBox (#14083) (#14165) Add support for transliterated citation keys (#13893) Update dependency org.apache.maven.plugins:maven-jar-plugin to v3.5.0 (#14321) Add link to latest development version (#14320) Parameterize tests in AuthorTest and AuthorListTest (#14135) Add AGENTS.md and AI_USAGE_POLICY.md from p5.js (#14316) Fix Nullwarnings - A (#14116) Update io.github.darvil82:terminal-text-formatter from 2.2.0 to 2.3.0c (#14317) Streamline maven repositories (#14315) Fix paths to included Java sources Add forgotten .. Update dependency io.github.darvil82:terminal-text-formatter to v2.3.0c (#14314) Chore(deps): Bump io.github.classgraph:classgraph from 4.8.181 to 4.8.184 in /versions (#14304) Chore(deps): Bump com.fasterxml:aalto-xml in /versions (#14311) Chore(deps): Bump commons-io:commons-io in /versions (#14310) Chore(deps): Bump org.apache.maven.plugins:maven-surefire-plugin (#14298) Disable fetcher-gui-test (#14308) ...
|
I don't understand something or I'm doing something wrong, but Колмогоров doesn't become Kolmogorov in citationkey automatically. I use: JabRef 6.0-alpha.101--2025-11-14--4e8d537 |
Member
Author
|
There is a new option in preferences. Go to "Citation key generator" (if I remember correctly in the morning 😄), and then tick "Transliterate fields for citation key" checkbox |
|
The problem is that this option is missing in the latest build (at least for Linux). Or did I download the wrong version of the program? 
The main build: 
|
Member
Author
|
Hmm, really missing. In latest commits I changed the location for being the top most, to be under "Remove characters... field". Either something bad with the PR, or we need to rebuild |
Member
|
When I tested the pr it was there. |
Member
|
@NeymanDmitry Sorry for the trouble, the new build was not published because we ran out of disk space... I retriggered a new build and you can now download the latest version again. |
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
* feat(citation-key-generator): add support for transliterating fields in citation key * feat(citation-key-generator): add transliteration action + refactor to class * chore(test): better format comments in TransliterationTest * chore(changelog): add changelog entry for transliteration * refactor(transliteration): refactor code after reviewing PR changes * refactor(transliteration): address review comments * chore(transliteration): reformat files * refactor(citationkey): append "for citation key" to "Transliterate fields" + change tests * chore(changelog): update CHANGELOG.md * Update CHANGELOG.md * fix(citationkey): address review comments * Fix duplicate entry in CHANGELOG.md * chore(submodules): fix submodules * refactor(citationkey): change true to false * chore(submodules): fix submodules --------- Co-authored-by: Subhramit Basu <subhramit.bb@live.in> Co-authored-by: Christoph <siedlerkiller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11377
Added:
Result:
Steps to test
Results:
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)