-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix for issue 12351 #14449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 12351 #14449
Conversation
…rador-commits/jabref into fix-for-issue-12351
Hey @paulamalvarador-commits!Thank you for contributing to JabRef! Your help is truly appreciated ❤️ We have automated checks in place, based on which you will soon get feedback if any of them are failing. In a while, maintainers will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
|
|
||
| @Path("libraries/{id}") | ||
| public class LibraryResource { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(LibraryResource.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that deleted? Seems like there is something wrong with your branch/not up to date
|
The title of the pull request must not start with "Fix for issue xyz". Please use a concise one-line summary that explains what the fix or change actually does. Example of a good title: "Prevent crash when importing malformed BibTeX entries". |
|
Your pull request modified git submodules. Please follow our FAQ on submodules to fix. |
Closes #12351
This PR improves the sizing behavior of the entry-table tooltip when the preview feature is enabled.
Previously, the tooltip became significantly larger than the actual preview content due to missing layout constraints.
The fix adjusts the tooltip container and the PreviewViewer sizing logic so the tooltip now adapts to its preferred size and remains compact.
Steps to test
Open Preferences → Entry preview.
Enable: “Show preview in entry table tooltip”.
Hover over any entry in the main table.
Observe that the tooltip now:
matches the size of the preview content,
no longer grows excessively,
remains readable and compact.
Screenshot
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)