Skip to content

Conversation

@ItsYash1421
Copy link

Closes #14658

Added "Import from Citavi..." link to the Welcome Tab's Start section, making it easier for users to migrate from Citavi. When clicked, the link opens a file picker filtered to Citavi XML files (.ctv6bak, .ctv5bak) and imports the selected file(s) into a new library tab. Citation keys from Citavi are preserved (left empty) as Citavi XML exports don't contain BibTeX citation keys, allowing users to generate them later according to their preferences.

Steps to test

  1. Launch JabRef
  2. On the Welcome Tab, locate the "Start" section
  3. Click on the new "Import from Citavi..." link (positioned after "Open library")
  4. In the file picker dialog, verify that only Citavi files (.ctv6bak, .ctv5bak) are shown by default
  5. Select a Citavi XML backup file (you can use test files from jablib/src/test/resources/org/jabref/logic/importer/fileformat/CitaviXmlImporterTest*.ctv6bak)
  6. Verify that:
    • The file imports successfully
    • A new library tab opens with the imported entries
    • Citation keys are empty (not auto-generated)
    • A notification shows the number of imported entries
  7. Test with multiple files to ensure batch import works

Mandatory checks

@github-actions
Copy link
Contributor

Hey @ItsYash1421! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow.

@github-actions github-actions bot added first contrib good first issue An issue intended for project-newcomers. Varies in difficulty. status: changes-required Pull requests that are not yet complete labels Dec 20, 2025
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 20, 2025
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 21, 2025
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 21, 2025
@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 21, 2025
@ItsYash1421 ItsYash1421 force-pushed the add-citavi-import-welcome-tab branch from abe6ee6 to 00092ab Compare December 21, 2025 17:50
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 21, 2025
@ItsYash1421 ItsYash1421 requested a review from koppor December 21, 2025 18:45
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't overwrite the citationkey generation settings.

(Note that we might not merge the PR, but it is still a nice excercise)

for (Path file : files) {
if (!Files.exists(file)) {
dialogService.showErrorDialogAndWait(Localization.lang("Import from Citavi"),
Localization.lang("File not found") + ": '" + file.getFileName() + "'.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use File %0 not found. See #14692

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 22, 2025
@github-actions
Copy link
Contributor

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: ui component: welcome-tab first contrib good first issue An issue intended for project-newcomers. Varies in difficulty.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Import from Citavi" to Welcome Tab

3 participants