-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add "Import from Citavi" to Welcome Tab #14672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add "Import from Citavi" to Welcome Tab #14672
Conversation
|
Hey @ItsYash1421! 👋 Thank you for contributing to JabRef! We have automated checks in place, based on which you will soon get feedback if any of them are failing. After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow. |
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abe6ee6 to
00092ab
Compare
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't overwrite the citationkey generation settings.
(Note that we might not merge the PR, but it is still a nice excercise)
| for (Path file : files) { | ||
| if (!Files.exists(file)) { | ||
| dialogService.showErrorDialogAndWait(Localization.lang("Import from Citavi"), | ||
| Localization.lang("File not found") + ": '" + file.getFileName() + "'."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use File %0 not found. See #14692
|
Your pull request conflicts with the target branch. Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line. |
Closes #14658
Added "Import from Citavi..." link to the Welcome Tab's Start section, making it easier for users to migrate from Citavi. When clicked, the link opens a file picker filtered to Citavi XML files (.ctv6bak, .ctv5bak) and imports the selected file(s) into a new library tab. Citation keys from Citavi are preserved (left empty) as Citavi XML exports don't contain BibTeX citation keys, allowing users to generate them later according to their preferences.
Steps to test
jablib/src/test/resources/org/jabref/logic/importer/fileformat/CitaviXmlImporterTest*.ctv6bak)Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)