Fixed Enable resetting of NameDisplayPreferences

[aaryyya]

User description

Closes #14412

Steps to test

Mandatory checks

• I own the copyright of the code submitted and I license it under the MIT license
• [/] I manually tested my changes in running JabRef (always required)
• [/] I added JUnit tests for changes (if applicable)
• [/] I added screenshots in the PR description (if change is visible to the user)
• [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
• I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

---

PR Type

Enhancement

---

Description

• Added private constructor with default display preferences

• Added getDefault() static method for creating default instances

• Added setAll() method to copy preferences from another instance

---

Diagram Walkthrough

flowchart LR
  A["NameDisplayPreferences"] -->|"private constructor"| B["Default values"]
  A -->|"getDefault()"| C["New instance"]
  A -->|"setAll()"| D["Copy preferences"]

Loading

File Walkthrough

Relevant files

Enhancement

NameDisplayPreferences.java Add default constructor and utility methods                            jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java Added private no-arg constructor that initializes with default display style and abbreviation style Added public static getDefault() method to create instances with default preferences Added public setAll() method to copy display and abbreviation style from another NameDisplayPreferences instance +16/-0

---

[qodo-free-for-open-source-projects]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡	🎫 #13109 🔴 Add Pseudonymization functionality to the CLI Make org.jabref.logic.pseudonymization.Pseudonymization available on the CLI Provide similar CLI experience to the consistency check Implement similar to org.jabref.cli.CheckConsistency class
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Missing null check: The setAll() method does not validate if the other parameter is null before accessing its methods. Referred Code public void setAll(NameDisplayPreferences other) { setDisplayStyle(other.getDisplayStyle()); setAbbreviationStyle(other.getAbbreviationStyle()); } Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Missing input validation: The setAll() method accepts external input without null validation, which could lead to NullPointerException. Referred Code public void setAll(NameDisplayPreferences other) { setDisplayStyle(other.getDisplayStyle()); setAbbreviationStyle(other.getAbbreviationStyle()); } Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	The PR is not aligned with the associated ticket The PR modifies NameDisplayPreferences, but the linked ticket #13109 is about adding a "Pseudonymization" feature to the CLI. This discrepancy should be resolved by either changing the code to match the ticket or linking the PR to the correct ticket. Examples: jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java [1-64] package org.jabref.gui.maintable; import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; public class NameDisplayPreferences { public enum DisplayStyle { NATBIB, AS_IS, FIRSTNAME_LASTNAME, LASTNAME_FIRSTNAME } ... (clipped 54 lines) Solution Walkthrough: Before: // File: jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java public class NameDisplayPreferences { // ... constructor and properties private NameDisplayPreferences() { this( DisplayStyle.NATBIB, AbbreviationStyle.LASTNAME_ONLY ); } public static NameDisplayPreferences getDefault() { return new NameDisplayPreferences(); } public void setAll(NameDisplayPreferences other) { // ... } } After: // Hypothetical new file: jabkit/src/main/java/org/jabref/cli/Pseudonymize.java // (to align with ticket #13109) public class Pseudonymize implements JabRefCLI.Command { @Override public String getName() { return "pseudonymize"; } @Override public void execute(String[] args) throws Exception { // Logic for CLI-based pseudonymization // 1. Parse command-line arguments // 2. Load the BibTeX database // 3. Apply pseudonymization logic // 4. Save the modified database } } Suggestion importance[1-10]: 10 __ Why: The suggestion correctly identifies a critical discrepancy between the PR's code changes and the linked ticket's requirements, which invalidates the PR's stated purpose.	High
Possible issue	Add null check to prevent NullPointerException In the setAll method, add a null check for the other parameter to prevent a NullPointerException if it is null. jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java [36-39] public void setAll(NameDisplayPreferences other) { + java.util.Objects.requireNonNull(other); setDisplayStyle(other.getDisplayStyle()); setAbbreviationStyle(other.getAbbreviationStyle()); } Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential NullPointerException in the newly added setAll method and provides a standard, robust solution to prevent it.	Medium
Update

[aaryyya]

Hey @calixtus i have made changes as suggested

[jabref-machine]

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Checkstyle (pull_request)" and click on it.

In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push.

[calixtus]

Clear your preferences and try to run again. I expect it to fail, because getBoolean etc. looks for a value in the defaults map, which is not present in backing store with cleared preferences.
Look at other preferences prs how they did. You need to deliver the default value from your default preferences object to that method meaning you have to adapt the helper methods.

[calixtus]

Will fail with fresh install / cleared preferences. Did you try it?

[aaryyya]

i will get on it and let u know

[calixtus]

Stick to the plan. Modify the helper methods and follow the guide in the issue description.

[calixtus]

And please test you changes manually.

[aaryyya]

NEW

private NameDisplayPreferences.AbbreviationStyle getNameAbbreviationStyle() {
        nameDisplayPreferences = NameDisplayPreferences.getDefault();
        return nameDisplayPreferences.getAbbreviationStyle();
    }

OLD

    private NameDisplayPreferences.AbbreviationStyle getNameAbbreviationStyle() {
        NameDisplayPreferences.AbbreviationStyle abbreviationStyle = NameDisplayPreferences.AbbreviationStyle.NONE; // default
        if (getBoolean(ABBR_AUTHOR_NAMES)) {
            abbreviationStyle = NameDisplayPreferences.AbbreviationStyle.FULL;
        } else if (getBoolean(NAMES_LAST_ONLY)) {
            abbreviationStyle = NameDisplayPreferences.AbbreviationStyle.LASTNAME_ONLY;
        }
        return abbreviationStyle;
    }

Hey @calixtus , since I can't use getBoolean method is this a right approach then?

[calixtus]

Sorry, I'm travelling. Back in about 12 days