Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New attempt with union merge... #1719

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Conversation

oscargus
Copy link
Contributor

Based on discussions in #1718 it seemed like it was time to try union merge for language files and CHANGELOG again.

@oscargus oscargus merged commit 982535c into JabRef:master Aug 11, 2016
@oscargus oscargus deleted the unionmerge branch August 11, 2016 19:15
@koppor
Copy link
Member

koppor commented Aug 11, 2016

In 8380fcf we disabled union merge for language files. I don't remember which PRs broke. Let's see, how that worked out.

In ac08efb, we disabled CHANGELOG.md union merging.

I will adapt the release how to to disable union merge of CHANGELOG.md directly after the release. Otherwise, changelogs of released (!) versions will be changed when merging a PR started before the release and changing the CHANGELOG. After thinking a bit longer, the attribute reset does not help as git's conflict resolution might be too clever and find lines moved even far away.

@koppor
Copy link
Member

koppor commented Aug 11, 2016

All @JabRef/developers have to take care when merging PRs directly after a release: The sections of CHANGELOG.md of the released version should not be changed.

Possible solution: We create a file CHANGELOG.master.md to collect changes and touch CHANGELOG.md only during release time. But this might be confusing. TOP for devcall. 😇

@oscargus
Copy link
Contributor Author

CHANGELOG is not so critical to me to have union merge in. It's just removing those three conflict markers in 12(?) translation files by hand every time someone has merge a PR with new translations in and you have to rebase that annoys me (and at least @Siedlerchr ).

ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants