Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview panel height is now saved immediately #1811

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Preview panel height is now saved immediately #1811

merged 1 commit into from
Aug 22, 2016

Conversation

chriba
Copy link
Contributor

@chriba chriba commented Aug 22, 2016

The Preview panel height is not stored when changed (only when JabRef is closed)

Steps

  • selecting an entry (thus opening the preview panel)
  • changing the preview panel height
  • closing the preview panel
  • selecting an entry (thus opening the preview panel)
  • the preview panel has the old height, not the new one we just changed

@Braunch Braunch added bug Confirmed bugs or reports that are very likely to be bugs stupro-ready-for-internal-review labels Aug 22, 2016
@@ -45,6 +45,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#

### Fixed
- Fixed [#1632](https://github.com/JabRef/jabref/issues/1632): User comments (@Comment) with or without brackets are now kept
- Preview panel height is now saved immediately, thus is show correctly if th panel height is changed, closed and opened again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Braunch
Copy link
Contributor

Braunch commented Aug 22, 2016

Fix typo in changelog otherwise LGTM

… if th panel height is changed, closed and opened again
@Braunch Braunch added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers stupro and removed stupro-ready-for-internal-review labels Aug 22, 2016
@oscargus
Copy link
Contributor

LGTM! 👍 (Will merge after the tests are done unless someone is faster...)

@stefan-kolb stefan-kolb merged commit c7ffe38 into JabRef:master Aug 22, 2016
@chriba chriba deleted the saveDividerLocationImmediately branch August 22, 2016 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants