Removed last Globals dependency in MetaData #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
status: ready-for-review
oscargus
force-pushed
the
lastglobalsinmetadata
branch
4 times, most recently
from
3f83bc3 to
5e68673
Compare
oscargus
force-pushed
the
lastglobalsinmetadata
branch
from
5e68673 to
7776ff6
Compare
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
* Removed last Globals dependency in MetaData * Removed Globals from logic tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bit of logic dependencies left to be able to move to model.
All Globals dependencies in
logic-test except one is now gone, so it is not possible to add an architecture test yet. It is only the Globals dependency of ExternalFileType that remains (good to be able to move external to logic and gui as well).