Add ID Fetcher in Entrytypedialog #1925
Conversation
|
To make it a bit clearer for the user, I would rename it "From ID based fetcher". |
|
Or just "From ID". I think the idea is really good, but I'm thinking that there may be a better location, like a separate menu item. However, I assume that this is the dialog shown when pressing "new entry" in the toolbar (which I rarely use). No really good idea, but later it may be worthwhile trying to e.g. have a side panel with that functionality (or rather separating the fetcher types in search and ID, I realize). |
| @@ -1640,3 +1640,8 @@ last_four_nonpunctuation_characters_should_be_numerals= | |||
| Remember_password?=Kom_ihåg_lösenord? | |||
|
|
|||
| shared=delad | |||
| Remember_password?= | |||
|
I'm also in favor of a new menu-item + dialog. This also provides you more room to include a bit more details. My proposal: Has the advantage that the user need not select the kind of ID he has (most of them are quite distinct and JabRef should be able to tell them apart) and he gets a preview of the entry (which tells him that we put the correct ID in) |
|
@tobiasdiez I like the idea, but @zellerdev should do it in addition. I like the current dialog by @zellerdev. I vote for doing both! I like the current "ID-based entry generator" (@zellerdev please rename acoordingly). Rename "Search" to "Generate". Is it possible to place "Cancel" to the right? |
zesaro
changed the title
| @Override | ||
| protected void done() { | ||
| if (isCancelled()) { | ||
| JOptionPane.showMessageDialog(null, "Fetching was canceled", "Canceled fetching", JOptionPane.INFORMATION_MESSAGE); |
There was a problem hiding this comment.
Why is the mesasge not localized?
|
Please add updated screenshot, also the German screenshot to be sure that everything is translated. Ater that, it should be good to go. |
| import org.jdesktop.swingx.VerticalLayout; | ||
|
|
||
| import static net.sf.jabref.gui.importer.fetcher.EntryFetchers.getIdFetchers; |
There was a problem hiding this comment.
I would prefer if you don't import this as static.
| dispose(); | ||
| } catch (FetcherException e) { | ||
| LOGGER.error("Error fetching from " + fetcher.getName(), e); | ||
| JOptionPane.showMessageDialog(null, Localization.lang("Error_while_fetching_from_%0", fetcher.getName()), Localization.lang("Error_while_fetching"), JOptionPane.ERROR_MESSAGE); |
There was a problem hiding this comment.
without underscore and also display error message.
|
Just some small remarks, then this could be merged. |
| @@ -2177,7 +2177,7 @@ Copied_version_to_clipboard=Copied_version_to_clipboard | |||
|
|
|||
| BibTeX_key=BibTeX_key | |||
| Message=Message | |||
|
|
|||
| ID-based_entry_generator=ID-based_entry_generator | |||
There was a problem hiding this comment.
The order of entries in JabRef_en.properties is important. Please move this together with No_entry_with_id_'%0'_for_fetche.... Maybe at the end of the file (as it is common for new entries)
|
Can you rewrite the code to depend on #1885 only. As #1923 depends on #1929, it will take more than this week to get it merged. I don't want to wait that long. - Update I think, you code does not depend on these two fetchers, but only your initial comment at this PR. Maybe just comment at these PRs that they should update |
koppor
changed the title
Add an extra field in the EntryTypeDialog to fetch the ID Based fetcher.
The field is in on the bottom of the dialog and is named
ID based generator.Normal
Searching
No internet connection
Error message
