Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sensible default settings for "Enable save actions" and "Cleanup" dialogs #2051

Merged
merged 14 commits into from
Oct 27, 2016
Merged

Create sensible default settings for "Enable save actions" and "Cleanup" dialogs #2051

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
67d35cb
Fixing: Sensible default settings for "Enable save actions" and "Clea…
motokito Sep 24, 2016
e3c0031
Sensible default settings for "Enable save actions" in database prope…
motokito Sep 28, 2016
0a3d823
Insert allTextField fieldName and refactoring the reset entries of da…
motokito Oct 6, 2016
e209e5a
CHANGELOG Fixing
motokito Oct 9, 2016
d597ad9
Feedback
motokito Oct 12, 2016
897fb9e
Create Recommend Button for BibTex and BibLatex and refactor reset bu…
motokito Oct 12, 2016
704eca7
Refactoring:
motokito Oct 13, 2016
e4afabf
Refactoring_15102016_2343:
motokito Oct 15, 2016
75497c1
Fix LocalizationConsistencyTest FAIL:
motokito Oct 17, 2016
c3dee55
Merge remote-tracking branch 'upstream/master' into cleanupDialogDefa…
motokito Oct 25, 2016
d18bbce
Refactoring:
motokito Oct 25, 2016
5677942
add OrdinalsToSuperscriptFormatter to recommand button
motokito Oct 25, 2016
b15e7fa
Merge remote-tracking branch 'upstream/master' into cleanupDialogDefa…
motokito Oct 27, 2016
b593ced
REFACTORING_27102016_0744:
motokito Oct 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/net/sf/jabref/logic/cleanup/Cleanups.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import net.sf.jabref.logic.formatter.bibtexfields.NormalizeDateFormatter;
import net.sf.jabref.logic.formatter.bibtexfields.NormalizeMonthFormatter;
import net.sf.jabref.logic.formatter.bibtexfields.NormalizePagesFormatter;
import net.sf.jabref.logic.formatter.bibtexfields.OrdinalsToSuperscriptFormatter;
import net.sf.jabref.logic.formatter.bibtexfields.UnicodeToLatexFormatter;
import net.sf.jabref.logic.layout.format.LatexToUnicodeFormatter;
import net.sf.jabref.model.cleanup.FieldFormatterCleanup;
Expand All @@ -35,7 +36,6 @@ public class Cleanups {
defaultFormatters.add(new FieldFormatterCleanup(FieldName.PAGES, new NormalizePagesFormatter()));
defaultFormatters.add(new FieldFormatterCleanup(FieldName.DATE, new NormalizeDateFormatter()));
defaultFormatters.add(new FieldFormatterCleanup(FieldName.MONTH, new NormalizeMonthFormatter()));
// defaultFormatters.add(new FieldFormatterCleanup(FieldName.BOOKTITLE, new OrdinalsToSuperscriptFormatter()));
DEFAULT_SAVE_ACTIONS = new FieldFormatterCleanups(false, defaultFormatters);

List<FieldFormatterCleanup> recommendedBibTeXFormatters = new ArrayList<>();
Expand All @@ -46,12 +46,14 @@ public class Cleanups {
recommendedBibTeXFormatters.add(new FieldFormatterCleanup(FieldName.JOURNAL, new UnicodeToLatexFormatter()));
recommendedBibTeXFormatters.add(new FieldFormatterCleanup(FieldName.AUTHOR, new UnicodeToLatexFormatter()));
recommendedBibTeXFormatters.add(new FieldFormatterCleanup(FieldName.EDITOR, new UnicodeToLatexFormatter()));
defaultFormatters.add(new FieldFormatterCleanup(FieldName.INTERNAL_ALL_TEXT_FIELDS_FIELD, new OrdinalsToSuperscriptFormatter()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommendedBibTeXFormatters instead of defaultFormatters (same below)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its still "defaultFormatters" here instead of "recommendedBibTeXFormatters"....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 😄

RECOMMEND_BIBTEX_ACTIONS = new FieldFormatterCleanups(false, recommendedBibTeXFormatters);

List<FieldFormatterCleanup> recommendedBibLaTeXFormatters = new ArrayList<>();
recommendedBibLaTeXFormatters.addAll(defaultFormatters);
recommendedBibLaTeXFormatters.add(new FieldFormatterCleanup(FieldName.TITLE, new HtmlToUnicodeFormatter()));
recommendedBibLaTeXFormatters.add(new FieldFormatterCleanup(FieldName.INTERNAL_ALL_TEXT_FIELDS_FIELD, new LatexToUnicodeFormatter()));
defaultFormatters.add(new FieldFormatterCleanup(FieldName.INTERNAL_ALL_TEXT_FIELDS_FIELD, new OrdinalsToSuperscriptFormatter()));
RECOMMEND_BIBLATEX_ACTIONS = new FieldFormatterCleanups(false, recommendedBibLaTeXFormatters);
}

Expand Down