Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 2012: Use bibtexformat for month field in medlinefetcher #2358

Merged
merged 2 commits into from
Dec 10, 2016

Conversation

zesaro
Copy link
Contributor

@zesaro zesaro commented Dec 9, 2016

Fix #2012
Checks if the month field is present. In the case it's present, the month field is set to bibtex format using MonthUtil.

@koppor
Copy link
Member

koppor commented Dec 9, 2016

Could you add a test case?

Medline tests are failing: https://travis-ci.org/JabRef/jabref/builds/182632279#L329

@zesaro
Copy link
Contributor Author

zesaro commented Dec 9, 2016

I just updated the test cases. As far as I understood it, this should be the normal behavior. So no additional tests should be necessary.

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 9, 2016
@stefan-kolb stefan-kolb merged commit aa53b5a into JabRef:master Dec 10, 2016
tobiasdiez pushed a commit to tobiasdiez/jabref that referenced this pull request Dec 10, 2016
…abRef#2358)

* use bibtexformat for month field in medlinefetcher

* update test cases
@zesaro zesaro deleted the issue2012 branch December 11, 2016 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants