-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datepicker fix #2405
Datepicker fix #2405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this looks good! It is nice that we are able to remove the custom date formatter completely (and thus its package also).
I wanted to test this in the UI, but somehow I am unable to configure my JabRef to display the timestamp field in the entry editor.
Documentation at http://help.jabref.org/en/TimeStamp Does not work with master and v3.8 on my side. v3.7 does not compile any more ("Could not find de.undercouch:citeproc-java:1.0.0-SNAPSHOT"). Does also not work with v3.6. The solution is to reset the preferences. Solution works for me. @matthiasgeiger Thank you for the fix. |
Does not work for me even after resetting the preferences... (JabRef-3.8.1-dev--snapshot--2016-12-20--master--b655bfd.jar) |
@mlep: After resetting the preferences, the timestamp field appears for me and the datepicker works as desired. The dev version you mention in your comment is not the most recent one, maybe it did not yet include the fix. Can you try again with JabRef-3.8.1-dev--snapshot--2016-12-20--master--62d55e1.jar |
Indeed, the calendar is displayed now. |
@mlep Indeed! Clear only works if a proper date is already in the field. If you insert something else, such as @matthiasgeiger Can you please address this? Since this PR is already merged, I guess we need a follow-up PR. |
Note: for me, it does not clear even if the field content looks good, like: |
Fix for #2403 - and as I was just touching this stuff again: I replaced our custom
EasyDateFormat
class with a standardDateTimeFormatter
[ ] Screenshots added (for bigger UI changes)[ ] Check documentation status (Issue created for outdated help page at help.jabref.org?)[ ] If you changed the localization: Did you rungradle localizationUpdate
?