Fix apostrophe conversion #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenhard
added
the
status: ready-for-review
Siedlerchr
approved these changes
Feb 1, 2017
|
Ich merge das mal rein und hoffe, dass cih das dann dan fürs erste erledigt hat |
Siedlerchr
added a commit
that referenced
this pull request
Feb 1, 2017
* upstream/master: (82 commits) Add access Rule for javafx to avoid Acces restricted in eclipse Fix apostrophe conversion (#2507) Fix Alain's name rename LocalizationBundle in Test folder (#2504) Fix eclipse bug again Update CHANGELOG.md Adapt IntelliJ Code Style.xml to checkstyle.xml Fix @param declaration and remove author to be consistent with other code Resolve conflicts using the versions javafx branch, not the master branch (and use alt+f8 instead of f8) Show development information Release v3.8.2 Always override JabRef.vmoptions in the installation folder Update install4j from 6.1.3 to 6.1.4 Update AUTHORS wget for new JREs Try vmOptionsFile Update JRE from 112 to 121 Change key binding for cleanup from F8 to ALT+F8 (#2496) Use https URL of www.jabref.org Save test reports as build artifacts on circle ci ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2500. This repairs the apostrophe handling in the LaTeX to unicode conversion broken by #2464 and maintains the special handling of apostrophes in conjunction with the character 'n' that #2464 intended to fix.
It increases complexity and reduces performance in the unicode conversion a tiny bit (through the additional checks that are now in there). Ultimately, the goal should be to replace the conversion with an external library.