Fix export of number + pubstate in OFFice XML #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export/import volumes <-> numberofvolume Export pubstate field as bibtex only field
Siedlerchr
added
the
status: ready-for-review
lenhard
approved these changes
Feb 3, 2017
| @@ -20,11 +20,13 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - Redesigned journal abbreviations dialog. | |||
| - Redesigned error console. | |||
| - All file dialogs now use the native file selector of the OS. [#1711](https://github.com/JabRef/jabref/issues/1711) | |||
| - The MS-Office XML export now exports the field `volumes` and `pubstate`. | |||
There was a problem hiding this comment.
Minor thing: This should be aligned with the other bullet points.
| @@ -26,6 +25,7 @@ @Unpublished{ | |||
| size = {1000}, | |||
| sourcetype = {Interview}, | |||
| timestamp = {2016.08.19}, | |||
| volumes = {10} | |||
| @@ -20,6 +19,7 @@ @Article{ | |||
| price = {10}, | |||
| school = {Gymnasium Unterrieden}, | |||
| size = {1000}, | |||
| volumes = {10}, | |||
|
Hm seems like a problem with spaces and tabs again
Am 03.02.2017 8:42 vorm. schrieb "Jörg Lenhard" <notifications@github.com>:
… ***@***.**** approved this pull request.
There are a few formatting things that should be fixed before merging, but
apart from that the code looks fine and is ready to go.
Thanks!
------------------------------
In CHANGELOG.md
<#2514 (review)>:
> @@ -20,11 +20,13 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- Redesigned journal abbreviations dialog.
- Redesigned error console.
- All file dialogs now use the native file selector of the OS. [#1711](#1711)
+- The MS-Office XML export now exports the field `volumes` and `pubstate`.
Minor thing: This should be aligned with the other bullet points.
------------------------------
In src/test/resources/net/sf/jabref/logic/exporter/
MsBibExportFormatTest1.bib
<#2514 (review)>:
> @@ -26,6 +25,7 @@ @Unpublished{
size = {1000},
sourcetype = {Interview},
timestamp = {2016.08.19},
+ volumes = {10}
Again, please align.
------------------------------
In src/test/resources/net/sf/jabref/logic/importer/fileformat/
MsBibImporterMsBibFieldsTest.bib
<#2514 (review)>:
> @@ -20,6 +19,7 @@ @Article{
price = {10},
school = {Gymnasium Unterrieden},
size = {1000},
+ volumes = {10},
Again, please align.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2514 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AATi5P-YB564PFpeg6iIrBxQ0Xbw08mIks5rYtpcgaJpZM4L1aT4>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2509
Export/import volumes <-> numberofvolume
Export pubstate field as bibtex only field
- [ ] Screenshots added (for bigger UI changes)- [ ] If you changed the localization: Did you rungradle localizationUpdate?