Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework File links logic #2529

Merged
merged 3 commits into from
Feb 8, 2017
Merged

Rework File links logic #2529

merged 3 commits into from
Feb 8, 2017

Conversation

stefan-kolb
Copy link
Member

@stefan-kolb stefan-kolb commented Feb 8, 2017 •
edited
Loading

Major changes:

  • Download from URL will now insert at first position (formerly last)
  • Get Fulltext from URL will now insert at first position(formerly last)
  • Add Button will now insert at last position (formerly at selected row)

image

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 8, 2017
Siedlerchr
Siedlerchr reviewed Feb 8, 2017
View reviewed changes
src/main/java/net/sf/jabref/gui/externalfiles/FindFullTextAction.java
FileListTableModel fileLinkModel = new FileListTableModel();
entry.getField(FieldName.FILE).ifPresent(fileLinkModel::setContent);
// add full text file link at first position
fileLinkModel.addEntry(0, file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if there is already a file linked?
Will the linked file then be moved one down?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the file link model is just a linked list

@Siedlerchr Siedlerchr merged commit 89eb15c into master Feb 8, 2017
@Siedlerchr Siedlerchr deleted the file-links branch February 8, 2017 20:13
Siedlerchr added a commit that referenced this pull request Feb 9, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into moveFileDir
ed8addf 
* upstream/master:
  Use LaTeX free title for CrossRef search #1424
  Check more results returned by CrossRef API for matching (#2531)
  Rework File links logic (#2529)
  Remove MIT string from lang files
  Translate new strings (#2528)
  Make DOIFetcher the default fetcher in new entry dialog (#2530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefan-kolb @Siedlerchr