Fixes displaying of Mr DLib recommendations #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and some other stylistic improvements)
koppor
added
the
status: ready-for-review
Siedlerchr
approved these changes
Mar 6, 2017
| @@ -1148,7 +1148,7 @@ public void stateChanged(ChangeEvent event) { | |||
| } | |||
|
|
|||
| // When the tab "Related articles" gets selected, the request to get the recommendations is started. | |||
| if (activeTab instanceof EntryEditorTabRelatedArticles) { | |||
| if (activeTab == relatedArticlePanel) { | |||
There was a problem hiding this comment.
Hm. I really wonder why this previously didn't work. But well, if it works now, then it's fine...
There was a problem hiding this comment.
EntryEditorTabRelatedArticles was AFAIK used as child. activeTab was a JPanel.
koppor
removed
the
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Mar 7, 2017
* upstream/master: (91 commits) fixed #2613 (#2623) Add MathSciNet as ID-based fetcher (#2621) Add icon + color and description to groups (#2612) Fixed wrong logger import (#2618) Cleanup window has a scrollbar now. (#2614) Added the locale to a newly created class Move ExportComparator and CustomExportList to the correct package (only used in preferences) Fixes displaying of Mr DLib recommendations (#2616) Fix title-related key patterns in BibtexKeyPatternUtil (#2610) Remove OrdinalsToSuperscriptFormatter from recommended biblatex save actions (#2601) Update pgjdbc to new major version Update Dependenices String Similary log4j wiremock mockito Fix exception when parsing groups which contain a top level group (#2611) Add "Remove group and subgroups" option (#2587) Fix #1104: group selection is preserved under tab change Fix several File Cleanup + Rename issues (#2415) Fixed a small error in the code comments Implement #1904: filter groups (#2588) Braces checking followup (#2598) Improve braces checking (#2593) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes koppor#231
Mr DLib did never load the recommendations, because of an NPE fix (#2567)