Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser no longer warns about empty BibTeX keys #2699

Merged
merged 3 commits into from
Apr 1, 2017
Merged

Parser no longer warns about empty BibTeX keys #2699

merged 3 commits into from
Apr 1, 2017

Conversation

tobiasdiez
Copy link
Member

As we have an integrity check for this and BibTeX keys are no longer required for the groups.
Issue was raised in #2599 (comment).

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 31, 2017
@Siedlerchr
Copy link
Member

LGTM, but you apparently forgot to adjust some parser test:
org.jabref.logic.importer.fileformat.BibtexParserTest > parseWarnsAboutEntryWithoutBibtexKey FAILED
Aftewards can be merged

@tobiasdiez tobiasdiez merged commit 185c722 into master Apr 1, 2017
@tobiasdiez tobiasdiez deleted the removeEmptyKeyWarning branch April 1, 2017 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr