Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Library of Congress as ID-fetcher #2865

Merged
merged 3 commits into from
May 24, 2017
Merged

Add Library of Congress as ID-fetcher #2865

merged 3 commits into from
May 24, 2017

Conversation

tobiasdiez
Copy link
Member

...as wished in forum

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 24, 2017
@Siedlerchr
Copy link
Member

Just check the coday issues (scoping + default constructor) and its ready for merge

@Siedlerchr Siedlerchr merged commit bdac5e8 into master May 24, 2017
@Siedlerchr Siedlerchr deleted the lccnSupport branch May 24, 2017 14:05
Siedlerchr added a commit that referenced this pull request May 27, 2017
* upstream/master: (23 commits)
  Implement #2785: resort groups using drag & drop (#2864)
  Add Library of Congress as ID-fetcher (#2865)
  Fix export and import of MS office day/year/month acessed fields (#2862)
  Adsurl to url (#2861)
  Update LICENSE.md
  Update
  Update LICENSE.md
  Update license file so that github recognize it properly
  Improve Issue Template Using a Collapsible Log Area
  Fix #2852: Improve performance of group filtering.
  Rename GroupSelector to GroupSidePane
  Fix #2843: Show information correctly in entry editor
  Remove old entry editor code related to focus selection
  Implement feedback
  Menu Greek Translation (#2836)
  Relaxed the regex to also match negative timezone formats when parsing pdf annotation dates (#2841)
  Update localization
  Remove unnecessary group code (and move remaining settings to preferences)
  Add Local Maven repo as first lookup resource, to avoid having duplicate libs in gradle and maven
  Implement #2786: Allow selection of multiple groups
  ...
Siedlerchr added a commit that referenced this pull request Jun 3, 2017
* upstream/master: (38 commits)
  Add link to "feature branch workflow"
  Support Annotations Created by Foxit (#2878)
  Fixes jacoco by excluding the fetcher tests from analysis (#2877)
  Fix entry editor (#2875)
  update bcprov-jdk15on from 1.56 -> 1.57
  update assertj-swing-junit from 3.5.0 -> 3.6.0
  update mockito-core from 2.7.22 -> 2.8.9
  update jfx from 0.11.0 -> 0.11.1
  update google guava from 21.0 -> 22.0
  Fix Divide by zero exception if rows is zero in Entry Editor Tab (#2873)
  Implement #2785: resort groups using drag & drop (#2864)
  Add Library of Congress as ID-fetcher (#2865)
  Fix export and import of MS office day/year/month acessed fields (#2862)
  Adsurl to url (#2861)
  Update LICENSE.md
  Update
  Update LICENSE.md
  Update license file so that github recognize it properly
  Improve Issue Template Using a Collapsible Log Area
  Fix #2852: Improve performance of group filtering.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants