Fix group storage #2978
Merged
Fix group storage #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenhard
added
groups
status: ready-for-review
|
I don't have time right now to have a closer look, so just a very quick remark/question: So I'm not sure if this explicit update is really necessary. But if its works we can also just merge it :-). Thanks anyway for having a look at this issue! |
|
Tested it locally and now the group information is stored when you create a new db, Importing works also. |
Siedlerchr
added a commit
that referenced
this pull request
Jul 11, 2017
* upstream/master: Eclipse J Add switch indentation for Eclipse and add some new missing formatting options Check for different editions in the duplicate check (#2991) Add CheckStyle Check for Constants (final static) (#2992) Add Remove link context menu entry in file editor (#2972) Fix DiVA tests Remove <pre> tag from entries fetched using MathSciNet (#2990) Fix Brazilian Portugese language loading (#2981) Use sftp's symlink command to provide symlink to latest version Update gradle from 4.0 to 4.0.1 Fix group storage (#2978) Fix keybindings in entry editor (#2971)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2932
It seems that up to now all group related changes in the UI were not actually stored in the MetaData and lost on save. This PR resets the group-related information in the MetaData whenever something group-related changes.
Hopefully I found all positions where that may happen. If tested it manually, but someone else needs to do this, too!
It also seems that IntelliJ decided to remove trailing whitespaces in the Changelog when I added my entry...
gradle localizationUpdate?