Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2993
The frequent events are due to the bidirectional binding which transfers every change directly into the BibEntry. If we want fewer events, the only solution will probably be to break the binding, which would be very disappointing for the JavaFX implementation. In my point of view the problem is not on the side of event creation. After all, every change should trigger an event and JavaFX triggers many changes. Imho, this should be fixed in how we react to events.
I also noticed the exception, but do not get a dialog. This seems to happen because of the save operation invoked by the backup.
A solution might be to do less backups, by:
This PR combines options 1. and 3., i.e.: The backup manager ignores events that are very minor and only does a backup if enough of them have happened (currently set to five).
What do you think?
gradle localizationUpdate
?