Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 3052 #3095

Merged
merged 3 commits into from
Aug 10, 2017
Merged

Fix for issue 3052 #3095

merged 3 commits into from
Aug 10, 2017

Conversation

halx4
Copy link
Contributor

@halx4 halx4 commented Aug 10, 2017

This is an atempt to fix the problem with entry editor focus as described in #3052. In detail, when EntryEditor opens up, it is not focused automatically. The desired behavior is to focus the first Textfield on any of the EntryEditor's tabs.

The way the fix is implemented: when EntryEditor is opened, the JFXPanel in which is the TabPane of the EntryEditor is getting the focus, The focus is given implicitly to a focusTraversable node contained in the JFXPanel. The selection of the node seems to be "random" (even though consistent for a given tree of nodes). As far as I've tested it consistently focuses the first Textfield on any tab, which is the desired behavior. I make this pull requested as suggested in #3052 discussion by @Siedlerchr .

I should mention that I ran gradle check which results in "6 tests failed" in my setup but this was also the result when I ran the test before making any change.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez merged commit a4b6099 into JabRef:master Aug 10, 2017
@tobiasdiez
Copy link
Member

Thanks for the PR!

@halx4 halx4 deleted the fix-for-issue-3052 branch August 10, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants