Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an atempt to fix the problem with entry editor focus as described in #3052. In detail, when
EntryEditor
opens up, it is not focused automatically. The desired behavior is to focus the firstTextfield
on any of theEntryEditor
's tabs.The way the fix is implemented: when
EntryEditor
is opened, theJFXPanel
in which is theTabPane
of theEntryEditor
is getting the focus, The focus is given implicitly to a focusTraversable node contained in theJFXPanel
. The selection of the node seems to be "random" (even though consistent for a given tree of nodes). As far as I've tested it consistently focuses the firstTextfield
on any tab, which is the desired behavior. I make this pull requested as suggested in #3052 discussion by @Siedlerchr .I should mention that I ran
gradle check
which results in "6 tests failed" in my setup but this was also the result when I ran the test before making any change.gradle localizationUpdate
?