Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger group display update when grouping changes #3111

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Trigger group display update when grouping changes #3111

merged 3 commits into from
Aug 16, 2017

Conversation

lenhard
Copy link
Member

@lenhard lenhard commented Aug 16, 2017

Attempts to fix #1903

Makes the maintable update whenever grouping changes and not just when group selection changes.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 16, 2017
LinusDietz
LinusDietz approved these changes Aug 16, 2017
View reviewed changes
Copy link
Member

@LinusDietz LinusDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinusDietz LinusDietz merged commit b8485f7 into master Aug 16, 2017
@LinusDietz LinusDietz deleted the maintable-update branch August 16, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusDietz LinusDietz LinusDietz approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Main table non updated properly when newly assigning an article to a group
3 participants
@lenhard @Siedlerchr @LinusDietz