Customjfxpanel #3128
Customjfxpanel #3128
Conversation
* upstream/master: Move event processing from source tab into entry editor (#3116) Update Menu_ja.properties (#3125) Update JabRef_ja.properties (#3126) Localization: French: Translation of new entries (#3124) Fix changelog - no date for fixes Fix markdown Additional filter functionality for Check Integrity popup (#3120) Workround: make snapcraft find jabref.desktop Enable publishing so that users do not need to execute --devmode Update jabref.desktop Enable publishing so that users do not need to execute --devmode Release beta version also on snapcraft Workround: make snapcraft find jabref.desktop Fix branch name Use newer image Set executable for all (and not for owner only) Add comment on version replacement Enable creation of an Ubuntu snap
| @@ -0,0 +1,136 @@ | |||
| /* | |||
| * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
@koppor This is a direct copy from the openfjx code, no modifications, Is this compatible with our license?
http://hg.openjdk.java.net/openjfx/8/master/rt/file/tip/modules/swing/src/main/java/javafx/embed/swing/InputMethodSupport.java
There was a problem hiding this comment.
No. It is GPLv2. Not compatible. However, the complete JDK has the linking exception. See http://hg.openjdk.java.net/openjfx/8/master/file/b80799b32c69/LICENSE#l326.
To avoid discussions with Linux distributions, please make a separate repository org.jabref.gui.customjfx with the same license file, a README.md and a gradle build script. The resulting JAR is then copied into https://github.com/JabRef/jabref/tree/master/lib.
There was a problem hiding this comment.
Yeah I already thought that it will become a problem. Will do.
There was a problem hiding this comment.
|
Tested under linux, works as expected |
Move field to variable
koppor
added
status: ready-for-review
|
It seems that something is missing for the source pane, but otherwise the PR is functional: #3028 (comment) |
|
I would vote for merging this in as it is. And I will see on thursday why this on the source tab thing is not working. I would create a follow up PR then |
|
OK for me. At least, this heals the issue at most places. |
|
Agreed. This repairs most of this problem for 4.0. At least it's now possible to enter the info in the normal entry editor |
* upstream/master: (269 commits) Customjfxpanel (#3128) Make constants more obvious; improve logging Rename variables and make use of Java8 streams Re-add "Normalize to BibTex name format" context menu item and menu item tooltips Tweak build.gradle and external-libraries Work in feedback Files can be dropped to entry preview panel to attach a file again. Update IntelliJ howto to IntelliJ version 2017.2 Move event processing from source tab into entry editor (#3116) Update Menu_ja.properties (#3125) Update JabRef_ja.properties (#3126) Localization: French: Translation of new entries (#3124) Fix changelog - no date for fixes Fix markdown Additional filter functionality for Check Integrity popup (#3120) Workround: make snapcraft find jabref.desktop Enable publishing so that users do not need to execute --devmode Update jabref.desktop Enable publishing so that users do not need to execute --devmode Release beta version also on snapcraft ...
gradle localizationUpdate?