Files can be dropped to entry preview panel to attach a file again. #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Aug 19, 2017
|
|
||
| if (t.isDataFlavorSupported(urlFlavor)) { | ||
| List<File> transferedFiles = (List<File>) t.getTransferData(DataFlavor.javaFileListFlavor); | ||
| files.addAll(transferedFiles.stream().map(file -> file.toPath()).collect(Collectors.toList())); |
There was a problem hiding this comment.
use static reference: File::toPath
There was a problem hiding this comment.
And mabye add a comment that it has to be a File object and not a path. I remember that I fixed this before the regression and that java only recognizes this, if it is file object;)
Siedlerchr
approved these changes
Aug 19, 2017
koppor
added
the
status: ready-for-review
Siedlerchr
approved these changes
Aug 19, 2017
lenhard
reviewed
Aug 20, 2017
| } | ||
|
|
||
| if (t.isDataFlavorSupported(urlFlavor)) { | ||
| List<File> transferedFiles = (List<File>) t.getTransferData(DataFlavor.javaFileListFlavor); |
There was a problem hiding this comment.
Just a nitpick, but since you're already at it could you please change this variables name from t to someting more meaningful?
Otherwise the code looks fine.
lenhard
approved these changes
Aug 20, 2017
koppor
removed
the
status: ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes koppor#245. The issue was caused during a code cleanup at #2723: https://github.com/JabRef/jabref/pull/2723/files#diff-093fbc56554f6c75313823ee81f28ec6L152
gradle localizationUpdate?