Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protected terms list in context menu when a new list is added. #3162

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Update protected terms list in context menu when a new list is added. #3162

merged 2 commits into from
Aug 28, 2017

Conversation

lenhard
Copy link
Member

@lenhard lenhard commented Aug 28, 2017

Fixes #3161

The result of the dialog needs to be evaluated after the dialog is actually finished and the update of the context menu needs to be called.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 28, 2017
@LinusDietz LinusDietz merged commit fd9e674 into master Aug 28, 2017
@LinusDietz LinusDietz deleted the protected-terms-update branch August 28, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusDietz LinusDietz LinusDietz approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenhard @Siedlerchr @LinusDietz