Skip to content

[WIP] Use v8 for citeproc #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[WIP] Use v8 for citeproc #3180

wants to merge 6 commits into from

Conversation

@koppor
Copy link
Member

@koppor koppor commented Sep 1, 2017 •
edited
Loading

This is a try to get the V8 engine into JabRef. This is a follow up to #2250, where a discussion of this is made.

V8 requires different JARs to be built as the V8 JARs are platform dependent. This is not easily possible and the stackoverflow question has no answer directly applicable.

Open issues:

  • Produce multiple fat jars
  • Integration in install4j
  • Update of the homepage

Context: When a user uses a preview based on citation styles, the preview gets slow:

grafik

To illustrate the performance gain, I made two videos using screentogif:

without V8

without-v8

with V8

with-v8

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

shitikanth and others added 6 commits April 17, 2017 18:17
@shitikanth @koppor
Use v8 engine for CSL (#2250)
5563811 
Add a dependency to com.eclipsesource.J2V8 (Java Bindings for V8) in build.gradle. Citeproc-java detects that V8 is present in the classpath and starts using it automatically.
@koppor
Introduce different configurations
513d71b
@koppor
Rename configurations
aec54db
@koppor
Begin to use gradle-java-flavours plugin (https://github.com/uklance/…
01b6abd 
…gradle-java-flavours)
@koppor
Add ...ShadowJar tasks
373cf1e 
Suggested by http://stackoverflow.com/a/43460153/873282
@koppor
Merge branch 'master' into use-V8-for-citeproc
7326369 
# Conflicts:
#	build.gradle
#	external-libraries.txt
@koppor koppor mentioned this pull request Sep 1, 2017
Closed
@koppor koppor mentioned this pull request Nov 10, 2017
Merged
6 tasks
@koppor koppor mentioned this pull request Dec 11, 2017
Closed
@koppor koppor self-assigned this Jan 12, 2018
@koppor koppor added the jabcon label Feb 5, 2018
@stefan-kolb stefan-kolb closed this Feb 6, 2018
@stefan-kolb stefan-kolb deleted the use-V8-for-citeproc branch February 7, 2018 11:32
@stefan-kolb stefan-kolb restored the use-V8-for-citeproc branch February 7, 2018 11:32
@stefan-kolb stefan-kolb deleted the use-V8-for-citeproc branch February 17, 2018 10:12
@koppor koppor mentioned this pull request Sep 12, 2019
Merged
6 tasks
@koppor
Copy link
Member Author

koppor commented Sep 29, 2019

Alternative could be https://github.com/graalvm/graaljs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@koppor koppor

Labels

dev: build-system [outdated] type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koppor @stefan-kolb @shitikanth