Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase relative size of abstract field in editor #3320

Merged
merged 4 commits into from
Oct 19, 2017
Merged

Increase relative size of abstract field in editor #3320

merged 4 commits into from
Oct 19, 2017

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Oct 18, 2017 •
edited
Loading

Someone had the abstract field in the "required" tab. Since all fields were treated the same way, the abstract field was as big as the other fields resulting in a inconvenient display. See http://discourse.jabref.org/t/entry-preview-in-version-4/827/7. With this PR the solution for the keywords field is adopted and the abstract gets a bigger weight.

Not yet ready for review, a bit of code cleanup is still coming.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 19, 2017
lenhard
lenhard approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code looks fine and the PR even passed the "user acceptance test".

Could you just clarify what all that BibtexSingleField weight parameters (that you removed here) were about? Do I understand it correctly that this was actually a feature duplication to our weight computation in the entry editor?

src/main/java/org/jabref/model/entry/FieldProperty.java
@@ -20,16 +17,13 @@
EDITOR_TYPE,
PAGINATION,
TYPE,
CROSSREF,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is crossref gone here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not used (only assigned) and there is single/multiple entry link which looks the proper generalization.

@tobiasdiez
Copy link
Member Author

Yes, the weights were previously used to determine the size of the field editors. I think our new approach is superior since now the model does not need to know anything about an entry editor at all and the size of the fields is determined in the gui, as it should be.

I'll merge this now.

@tobiasdiez tobiasdiez merged commit 1751cba into master Oct 19, 2017
@tobiasdiez tobiasdiez deleted the weightMultiline branch October 19, 2017 10:35
Siedlerchr added a commit that referenced this pull request Oct 20, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into exportPdf
f29066c 
* upstream/master:
  Small fix in drag and drop handler of linked files (#3328)
  Fix NPE in MainTable (#3318)
  Increase relative size of abstract field in editor (#3320)
Siedlerchr added a commit that referenced this pull request Oct 27, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixSetFiles
1c12a4d 
* upstream/master: (31 commits)
  Source tab entry duplication (#3360)
  Use CITE_COMMENT not only for external latex editors but also for cop… (#3351)
  Updating with new translations (#3348)
  Upgrade error-prone (#3350)
  Jabref_pt_BR partially updated (#3349)
  Used late initialization for context menus (#3340)
  Fix NPE when calling with bib file as cmd argument (#3343)
  update mockito-core from 2.10.0 -> 2.11.0 (#3338)
  Remove underscore in Localized messages (#3336)
  Localisation: French: new entries translated (#3337)
  Refactoring: Lazy init of all editor tabs (#3333)
  Initializing EntryEditor Tabs on focus (#3331)
  Fix #3292: annotations are now automatically refreshed (#3325)
  Change integrity message for names depending on database mode (#3330)
  Fix location bundle with fast access (#3327)
  Small code cleanup
  Fix "path not found" exception
  Small fix in drag and drop handler of linked files (#3328)
  Fix NPE in MainTable (#3318)
  Increase relative size of abstract field in editor (#3320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenhard lenhard lenhard approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasdiez @Siedlerchr @lenhard