Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix threading issues #3486

Merged
merged 4 commits into from
Dec 5, 2017
Merged

Fix threading issues #3486

merged 4 commits into from
Dec 5, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 4, 2017 •
edited
Loading

Fixes #3485 and #3435

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 4, 2017
lenhard
lenhard approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@lenhard lenhard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine and I just tested this locally. I do no longer get the exception described in #3435, but I still get the exception described in #3485. Note that I did not double click the entries in the integrity check, I just clicked around on different entries (as described in the issue) and eventually the exception appears.

So, it seems that the PR is halfway there.

@Siedlerchr
Copy link
Member Author

This should be fixed now, I reverted to my initial idea. I heavily clicked around and switched tabs in the entry editor and randomly selected things in the main table and in the integrity check table. No longer exception

@lenhard
Copy link
Member

lenhard commented Dec 5, 2017

I have tested it locally and can confirm that it is working now.

@tobiasdiez tobiasdiez merged commit c9874ec into master Dec 5, 2017
@tobiasdiez tobiasdiez deleted the integritycheckfx branch December 5, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenhard lenhard lenhard approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @lenhard @tobiasdiez