-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3505: Another try to fix the NPE in the search bar #3512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Seems really odd this error only occurs on certain systems
Search bar appears here. I think, @j0hannes should run the build at his system. Currently, one has to checkout the code and execute |
@koppor I just rebuilt the package from git and the search bar is still not there. |
@j0hannes did you checked-out the branch |
Anyway, I merge this now since the code still works under normal conditions and might help in others. So a new checkout of the master branch should work now. |
@tobiasdiez Now it's back. The package will certainly only use the master branch; I though it was already merged there. |
@j0hannes thanks for the feedback and your help debugging this issue! Much appreciated. |
* upstream/master: (108 commits) Fetcher for IACR eprints (#3473) Update internal state of DatabaseChangeMonitor when external changes … (#3503) Fixes #3505: Another try to fix the NPE in the search bar (#3512) Replace ' with ' so that our HTML preview can handle it correctly Added a "Clear text" button in right click menu within the text boxes. (#3475) Add reset to English language after a test New translations JabRef_en.properties (German) Remove ampersand in non-menu localizations New translations JabRef_en.properties (German) New translations Menu_en.properties (German) New translations Menu_en.properties (German) New translations JabRef_en.properties (Vietnamese) New translations JabRef_en.properties (Italian) New translations Menu_en.properties (Italian) New translations JabRef_en.properties (Indonesian) New translations Menu_en.properties (Indonesian) New translations JabRef_en.properties (Greek) New translations Menu_en.properties (Greek) New translations Menu_en.properties (Japanese) New translations JabRef_en.properties (German) ... # Conflicts: # build.gradle
Fiexes #3505
I think, I managed to locate the problem of the NPE and the missing search bar. Apparently, in some conditions the syntax
../
to access the parent in a path does not work for resources. Thus the css file is not found, resulting in a NPE.gradle localizationUpdate
?