Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickfix to get build running on all platforms #3638

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Quickfix to get build running on all platforms #3638

merged 1 commit into from
Jan 16, 2018

Conversation

LinusDietz
Copy link
Member

The current version does not compile on my computer locally. This PR fixes it. It was already discussed with @halirutan on gitter.

/Users/dietzl/git/jabref/src/main/java/org/jabref/gui/util/IconValidationDecorator.java:42: error: createDecorationNode(ValidationMessage) in IconValidationDecorator cannot override createDecorationNode(ValidationMessage) in GraphicValidationDecoration
private Node createDecorationNode(ValidationMessage message) {
^
attempting to assign weaker access privileges; was protected

@LinusDietz LinusDietz added [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jan 16, 2018
@Siedlerchr Siedlerchr merged commit 57f954d into master Jan 16, 2018
@Siedlerchr Siedlerchr deleted the fix-build branch January 16, 2018 16:06
Siedlerchr added a commit that referenced this pull request Jan 24, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
3f85f65 
* upstream/master: (46 commits)
  Replace openoffice jars with libreoffice  jars (#3662)
  Export no empty lines in RIS format (#3661)
  Remove apache commons logging in favor of slf4j + log4j for JAVA 9 (#3653)
  fix isbn fetcher test as Joshua Bloch has published a new revivsion of Effetive Java convert to junit5 jupiter
  Extend RIS import with multiple fields (#3642)
  Fix ICAR fetcher test which resulted in build failure (#3654)
  New translations JabRef_en.properties (French) (#3650)
  Add link to MADR and fix typo
  [WIP] Add "Convert to BibTeX format" cleanup (#3541)
  Fix typo
  Fix typo
  Quickfix to get build running on all platforms (#3638)
  New translations JabRef_en.properties (French)
  New translations JabRef_en.properties (Vietnamese)
  New translations JabRef_en.properties (Chinese Simplified)
  New translations JabRef_en.properties (Dutch)
  New translations JabRef_en.properties (French)
  New translations JabRef_en.properties (German)
  New translations JabRef_en.properties (Greek)
  New translations JabRef_en.properties (Indonesian)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@halirutan halirutan Awaiting requested review from halirutan

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

Assignees
No one assigned
Labels
dev: build-system [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinusDietz @Siedlerchr