Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement special field and file columns #3647

Merged
merged 5 commits into from
Jan 29, 2018
Merged

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Jan 18, 2018

Re-add icons for special fields and linked files to maintable. They work as before (i.e. toggle on click or context menu depending on the type of field) and look almost identical.
As a small visual clue the clickable icons are shown grayish for the currently hovered row.

image

The ranking column does not yet work (subject of another PR as soon as my PR for a bug in controls.fx is merged).


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 18, 2018
@tobiasdiez tobiasdiez changed the title Reimplement special field columns Reimplement special field and file columns Jan 19, 2018
@tobiasdiez tobiasdiez merged commit fbc5707 into javafxTable Jan 29, 2018
@tobiasdiez tobiasdiez deleted the specialColumns branch January 29, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant