Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually improve display of maintable #3689

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Feb 3, 2018

A few visual improvements for the new maintable.
As it should be for a "visual PR", I only had to touch the stylesheet - I love JavaFX ;-).

  • Use the same color for the focus of text-input as for the other controls (e.g. tabs, selected row)
    image

  • Remove space between tab header and content (previously, there was a small gray gap below the header)
    image

  • Replace JavaFX scrollbar by "flat version" and display scrollbars only if control has focus
    image


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 3, 2018
@Siedlerchr
Copy link
Member

It would be nice if you could take a look at this, too: I have no idea if its a stylesheet issue
#3639

@tobiasdiez tobiasdiez merged commit 4ea3f35 into maintable-beta Feb 6, 2018
@tobiasdiez tobiasdiez deleted the flatTextbox branch February 6, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants