Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use streams in group matcher #3696

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Use streams in group matcher #3696

merged 1 commit into from
Feb 6, 2018

Conversation

tobiasdiez
Copy link
Member

Just a small change in the groups matcher code to use streams instead of old-style for-loops.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 5, 2018
@Siedlerchr Siedlerchr merged commit bd3ef32 into master Feb 6, 2018
@tobiasdiez tobiasdiez deleted the fix3667 branch February 6, 2018 10:17
Siedlerchr added a commit that referenced this pull request Feb 6, 2018
* 'master' of github.com:JabRef/jabref:
  Allow spaces in DOIs
  Remove irrelevant log messages during XMP reading
  Adapt log4j configuration for cleaner junit tests #3511
  Eclipse Django style #3655
  Better code style for chained methods
  Update build.gradle
  Update build.gradle
  cleanup and refactoring in DuplicateCheck class
  code review fixes - consider pages of the same book separately in duplications detection process; add more tests
  differentiate inbooks with the same author and title, but different chapter
  Remove deprecated static BibtexParser.parse method
  Use stream in matcher (#3696)
  Add some BibtexNameFomatter comments
  Add exception for Jacoco
  Set jacoco toolVersion earlier
  set jacoco version globally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants