Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Dublin Core #3710

Merged
merged 17 commits into from
Feb 20, 2018
Merged

[WIP] Dublin Core #3710

merged 17 commits into from
Feb 20, 2018

Commits on Feb 7, 2018

  1. [WIP] Dublin core 

    Fixes JabRef#938
    @johannes-manner
    johannes-manner committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    282f066 View commit details
    Browse the repository at this point in the history

  2. [WIP] Remove double empty lines

    @johannes-manner
    johannes-manner committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    b88c1c8 View commit details
    Browse the repository at this point in the history

  3. Fix PdfXmpImporterTests 

    PdfXmpImporterTest:testImportEntries()
PdfXmpImporterTest:testIsRecognizedFormat()

Removed to much code when refactoring the XMPUtil. Non XMP metadata are also relevent, when retrieving org.apache.pdfbox.pdmodel.PDDocumentInformation
    @johannes-manner
    johannes-manner committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    3e0dd1d View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. Merge branch 'master' of https://github.com/JabRef/jabref into dublin… 

    …-core
    @johannes-manner
    johannes-manner committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    20d4c8a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Update pdfbox and migrate to xmpbox 

    Update pdfbox and fontbox from 1.8.13 to 2.0.8 and migritate from jempbox to xmpbox.  See pull JabRef#1096.

Next step: Writing test cases for XMPUtil (DublinCore).
    @johannes-manner
    johannes-manner committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    c593f2b View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Refactor extraction from DublinCoreSchema 

    Travis build failed because of an exceeded NPath complexity of a single method. Method was refactored and cleaned up.
    @johannes-manner
    johannes-manner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    cddba9d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/JabRef/jabref into dublin… 

    …-core

Merge
    @johannes-manner
    johannes-manner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    06fbcba View commit details
    Browse the repository at this point in the history

  3. Added some tests. 71% code coverage for XMPUtil 

    The tests cover the most important use cases, which include reading and writing metadata from pdf files. Both formats, DublinCore and PDMetadata (which are no XMP metadata) are tested.
    @johannes-manner
    johannes-manner committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    69b712f View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Separated XMPUtils in a reader and a writer utitlity class.

    @johannes-manner
    johannes-manner committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    ae26532 View commit details
    Browse the repository at this point in the history

  2. removed some codeConv violations

    @johannes-manner
    johannes-manner committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    9cc529f View commit details
    Browse the repository at this point in the history

  3. add meaningful names in DublinCoreExtractor and use StringUtils.isNul… 

    …lOrEmpty
    @johannes-manner
    johannes-manner committed Feb 16, 2018
    4 Configuration menu
    Copy the full SHA
    366aeed View commit details
    Browse the repository at this point in the history

  4. Log exception in XMPUtilShared

    @johannes-manner
    johannes-manner committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    8c2b446 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Write multiple dublinCore entries works 

    XMPUtilWriter supports mutliple metadata entries in dublinCore and a single entry in the PDDocumentInformation.
    @johannes-manner
    johannes-manner committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    79f1134 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. Reading multiple entries also works 

    Reading mulitple BibEntries in DublinCore format now also works. If you want to test the reading of multiple entries, the PDF file JabRef_multipleMetaEntries.pdf contains three metadata entries in DublinCore for testing locally.
    @johannes-manner
    johannes-manner committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    be7db0f View commit details
    Browse the repository at this point in the history

  2. Changed Optional<List<>> to List<> and fix write tests

    @johannes-manner
    johannes-manner committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    d32e8d7 View commit details
    Browse the repository at this point in the history

  3. Import automatically all metadata entries 

    Imports all metadata entries of a PDF file.
    @johannes-manner
    johannes-manner committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    d5dd993 View commit details
    Browse the repository at this point in the history

  4. Renamed XMP -> Xmp 

    Renamed (hopefully) all occurences of XMP to Xmp to stay with the  Google's Casing rules.
    @johannes-manner
    johannes-manner committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    523a1f3 View commit details
    Browse the repository at this point in the history