Fix Some Codacy Issues #3724
Merged
Fix Some Codacy Issues #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8359015
LinusDietz
added
status: ready-for-review
Siedlerchr
approved these changes
Feb 15, 2018
lenhard
approved these changes
Feb 15, 2018
There was a problem hiding this comment.
When you do stuff like this, then please explain in the description what kind of issues you are fixing. Here you mainly removed unused variables. That's not obvious from the div. I have to look in the code to check all this. If you state it beforehand then (based on the results from travis), these things are much easier to check.
|
@lenhard well that's why I have added microcommits with the corresponding messages |
|
Point taken :) You just don't see these messages when you go to the code page of the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it might be good to reduce the number of Codacy issues, so I started hunting them.
To keep these changes reviewable, I will open a new PR for the next batch.
Also I plan to adapt the codacy configuration to reduce false positives.