Meaningful button review field migration #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusDietz
added
bug
Siedlerchr
reviewed
Feb 21, 2018
| panel, | ||
| bibKeys + " " + | ||
| Localization.lang("has/have both a 'Comment' and a 'Review' field.") + "\n" + | ||
| Localization.lang("Since the 'Review' field was deprecated in JabRef 4.2, these two fields are about to be merged into the 'Comment' field.") + "\n" + | ||
| Localization.lang("The conflicting fields of these entries will be merged into the 'Comment' field."), | ||
| Localization.lang("Review Field Migration"), JOptionPane.DEFAULT_OPTION, JOptionPane.WARNING_MESSAGE); | ||
| Localization.lang("Review Field Migration"), JOptionPane.DEFAULT_OPTION, JOptionPane.WARNING_MESSAGE, null, options, options[0]); |
There was a problem hiding this comment.
Maybe not a "Warning message", in fact it's an information message. The user can't do anything about it.
There was a problem hiding this comment.
Well, infact it's a bit more important than just a simple notification, but I'd be open if others agree with you I'ts gonna be changed.
koppor
reviewed
Feb 21, 2018
| @@ -20,7 +20,7 @@ public void performAction(BasePanel basePanel, ParserResult parserResult) { | |||
|
|
|||
| migration.performMigration(parserResult); | |||
| List<BibEntry> conflicts = MergeReviewIntoCommentMigration.collectConflicts(parserResult); | |||
| if (new MergeReviewIntoCommentConfirmationDialog(basePanel).askUserForMerge(conflicts)) { | |||
| if (!conflicts.isEmpty() && new MergeReviewIntoCommentConfirmationDialog(basePanel).askUserForMerge(conflicts)) { | |||
There was a problem hiding this comment.
I think, this makes it not better. Now, JabRef migrates WITHOUT ANY notification. The old way was better. It showed that something was migrated.
There was a problem hiding this comment.
Well, then lets discuss this again: The rationale behind #3658 was that the warning should be displayed iff there is BOTH a comment and and review field present and perform the migration silently nonetheless.
tobiasdiez
approved these changes
Feb 21, 2018
|
Oh, JabRef should inform that something happend. Otherwise, it is not
clear, why there is a star. JabRef currently does not have the power to
show what it has changed... This is strange in the case of save actions,
but this can be explained.
IMHO consistency in the UI is an important feature. In the case of pdf/ps
fields, we show a popup. I can agree that we do not support "no migration"
and prevent users of creating bibtex entries with "comment". However, the
tool itself should communicate that it changed the database!
…On Feb 21, 2018 7:40 PM, "Tobias Diez" ***@***.***> wrote:
***@***.**** approved this pull request.
I'm happy with the current solution (i.e., only show when fields are
merged and use warning icon).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3762 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTafvyUW7Vdo8wSLxzL43f1zCrikmhlks5tXGMFgaJpZM4SN53y>
.
|
|
OK, the text might have to be adapted. Maybe, the first line could read: "Your bibliography contains review fields and possibly comment fields." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes koppor#312.
Sorry, the PR quality of #3658 was really not so good.