Added <any file type> to the Import File Filter Dialog. #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Feb 22, 2018
| FileDialogConfiguration fileDialogConfiguration = new FileDialogConfiguration.Builder() | ||
| .addExtensionFilter(allImports) | ||
| .addExtensionFilters(extensions) | ||
| .withInitialDirectory(Globals.prefs.get(JabRefPreferences.IMPORT_WORKING_DIRECTORY)) | ||
| .build(); | ||
| fileDialogConfiguration.getExtensionFilters().add(new FileChooser.ExtensionFilter("Any file", "*.*")); |
There was a problem hiding this comment.
If you could just wrap that "Any file" in Localization.lang, I would be happy.
Otherwise LGTM! 👍
There was a problem hiding this comment.
@Siedlerchr With this addition, is
jabref/src/main/java/org/jabref/gui/util/FileFilterConverter.java
Lines 47 to 49 in 58c2c7a
now obsolete?
There was a problem hiding this comment.
Still a little difference, but you are in general right.
There was a problem hiding this comment.
So what exactly is the difference? Should we just remove the old one?
There was a problem hiding this comment.
All available import formats = All supported file extension
Any file = Any extension not registered as default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added . (any file) to the File Filter Dialog. Now you can choose any file to import to try to import to your library. Fixes #3757.