[WIP] Update latex2unicode from 0.2.2 -> 0.2.4

[LinusDietz]

• Investigate why this is failing
• fix tests

[LinusDietz]

So this is due to @tomtung fixing a feature we wished for long: tomtung/latex2unicode#8

tomtung/latex2unicode@6879cbb

[Siedlerchr]

It maybe failing because we use our own replacement char as a workaround , I think. Not sure if it's this issue or another

[stefan-kolb]

Looks like this is the case. The question is do we really want this behavior?

Failures (4):
  JUnit Jupiter:LatexToUnicodeFormatterTest:unknownCommandKeepsArgument()
    MethodSource [className = 'org.jabref.logic.layout.format.LatexToUnicodeFormatterTest', methodName = 'unknownCommandKeepsArgument', methodParameterTypes = '']
    => org.opentest4j.AssertionFailedError: expected: <bbbb> but was: <\aaaabbbb>
       org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:52)
       org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:186)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:181)
       org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:486)
       org.jabref.logic.layout.format.LatexToUnicodeFormatterTest.unknownCommandKeepsArgument(LatexToUnicodeFormatterTest.java:118)
       sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
       sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       java.lang.reflect.Method.invoke(Method.java:498)
       [...]
  JUnit Jupiter:LatexToUnicodeFormatterTest:unknownCommandWithEmptyArgumentIsIgnored()
    MethodSource [className = 'org.jabref.logic.layout.format.LatexToUnicodeFormatterTest', methodName = 'unknownCommandWithEmptyArgumentIsIgnored', methodParameterTypes = '']
    => org.opentest4j.AssertionFailedError: expected: <> but was: <\aaaa>
       org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:52)
       org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:186)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:181)
       org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:486)
       org.jabref.logic.layout.format.LatexToUnicodeFormatterTest.unknownCommandWithEmptyArgumentIsIgnored(LatexToUnicodeFormatterTest.java:123)
       sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
       sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       java.lang.reflect.Method.invoke(Method.java:498)
       [...]
  JUnit Jupiter:LatexToUnicodeFormatterTest:testFormatStripLatexCommands()
    MethodSource [className = 'org.jabref.logic.layout.format.LatexToUnicodeFormatterTest', methodName = 'testFormatStripLatexCommands', methodParameterTypes = '']
    => org.opentest4j.AssertionFailedError: expected: <-> but was: <\mbox->
       org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:52)
       org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:186)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:181)
       org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:486)
       org.jabref.logic.layout.format.LatexToUnicodeFormatterTest.testFormatStripLatexCommands(LatexToUnicodeFormatterTest.java:25)
       sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
       sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       java.lang.reflect.Method.invoke(Method.java:498)
       [...]
  JUnit Jupiter:LatexToUnicodeFormatterTest:unknownCommandIsIgnored()
    MethodSource [className = 'org.jabref.logic.layout.format.LatexToUnicodeFormatterTest', methodName = 'unknownCommandIsIgnored', methodParameterTypes = '']
    => org.opentest4j.AssertionFailedError: expected: <> but was: <\aaaa>
       org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:52)
       org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:186)
       org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:181)
       org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:486)
       org.jabref.logic.layout.format.LatexToUnicodeFormatterTest.unknownCommandIsIgnored(LatexToUnicodeFormatterTest.java:113)
       sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
       sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       java.lang.reflect.Method.invoke(Method.java:498)
       [...]

[stefan-kolb]

Currently the new update preserves the command \afor example, but strips the brackets like \a{hhh}->\ahhh.

@tomtung @JabRef/developers What about the behavior for these cases?
\aaaa{bbbb} currently gets \aaaabbbb
\aaaa{} currently gets \aaaa
Shouldn't the braces be preserved as well?

[koppor]

+1 for preserving the braces

[LinusDietz]

Devcall: We cannot update to 0.2.4 because this destroys valid latex code. Need to create a Pull Request at latex2Unicode.

[stefan-kolb]

tomtung/latex2unicode#9

[stefan-kolb]

We got an answer from Tom and need to discuss this. decision seems nontrivial to me.

[tobiasdiez]

Whats the status here? If we want to upgrade to Java 9, we need to update the latex2unicode library, see #3421.

[koppor]

If I recall it correctly, we need to fork the librrary or reimplement it on our own ... again. @oscargus? 😇 Am Mi., 19. Dez. 2018, 22:34 hat Tobias Diez <notifications@github.com> geschrieben:

…

Whats the status here? If we want to upgrade to Java 9, we need to update the latex2unicode library, see #3421 <#3421>. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#3781 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABTafsWC3FouORjhFUlA59wTQSE6QcbDks5u6iRYgaJpZM4ST3At> .

[tobiasdiez]

tomtung/latex2unicode#9 is now fixed. Updating the library leads some export test failures, which I have already fixed on the jdk9 branch. Thus, I've pushed the update there d54d6ff

[stefan-kolb]

Great Work Tobias! Tobias Diez <notifications@github.com> schrieb am Mo., 3. Juni 2019, 22:20:

…

tomtung/latex2unicode#9 <tomtung/latex2unicode#9> is now fixed. Updating the library leads some export test failures, which I have already fixed on the jdk9 branch. Thus, I've pushed the update there d54d6ff <d54d6ff> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3781?email_source=notifications&email_token=AAQK2Q2XEFIHSBH6BYLOCCTPYV4JNA5CNFSM4ESPOAW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2SL6Q#issuecomment-498411002>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQK2QYMVAQOSSUVEQG6RJTPYV4JNANCNFSM4ESPOAWQ> .