Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show empty group pane if no database is open #3785

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Show empty group pane if no database is open #3785

merged 1 commit into from
Feb 27, 2018

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Feb 27, 2018 •
edited
Loading

Fixes an issue where the group tree of the last database is still shown even after the database was closed.
Reported in #3621 (comment)

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 27, 2018
@tobiasdiez tobiasdiez mentioned this pull request Feb 27, 2018
Merged
35 tasks
Siedlerchr
Siedlerchr reviewed Feb 27, 2018
View reviewed changes
src/main/java/org/jabref/gui/JabRefFrame.java
@@ -278,6 +278,7 @@ private void init() {
*/
EasyBind.subscribe(tabbedPane.getSelectionModel().selectedItemProperty(), e -> {
if (e == null) {
Globals.stateManager.activeDatabaseProperty().setValue(Optional.empty());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, Optional sollte man eigentlich nicht als Parameter nutzen.

Copy link
Member Author

@tobiasdiez tobiasdiez Feb 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this is the only way because activeDatabaseProperty uses the generic Property<T> (with T = Optional<Database>), which provides setValue(T value).

@Siedlerchr Siedlerchr merged commit 01bb49e into maintable-beta Feb 27, 2018
@Siedlerchr Siedlerchr deleted the fixCloseAllDatabasesGroups branch February 27, 2018 15:38
Siedlerchr added a commit that referenced this pull request Feb 27, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into editStrin…
f1e4cd8 
…gsjavafx

* upstream/maintable-beta:
  Save order of columns across sessions (#3783)
  Allow side pane to be completely hidden (#3784)
  Show empty group pane if no database is open (#3785)
  Reenable drag'n'drop support for tabs / libraries (#3688)
Siedlerchr added a commit that referenced this pull request Feb 28, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into fixdragan…
262e0c9 
…drop

* upstream/maintable-beta:
  Save order of columns across sessions (#3783)
  Allow side pane to be completely hidden (#3784)
  Show empty group pane if no database is open (#3785)
  Reenable drag'n'drop support for tabs / libraries (#3688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr