Fix Copy linked files dialog showing NPE when no linked files #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix exception when no linked file exists
Siedlerchr
added
the
status: ready-for-review
tobiasdiez
requested changes
Mar 8, 2018
| @@ -103,6 +103,10 @@ public CopyFilesTask(BibDatabaseContext databaseContext, List<BibEntry> entries, | |||
| } | |||
| } | |||
| updateMessage(Localization.lang("Finished copying")); | |||
|
|
|||
| if (newPath == null) { | |||
There was a problem hiding this comment.
newPath is an optional, so it should never be null (for the same reason as for collections). Please init newPath as empty (and then this if test should not be necessary).
There was a problem hiding this comment.
Ah thanks! didn't catch that it was an optional
| } | ||
|
|
||
| private void showDialog(List<CopyFilesResultItemViewModel> data) { | ||
|
|
There was a problem hiding this comment.
What's the reason for the newlines?
|
travis fails for some timeout reason not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3818
(ignore the branch name, I thought it was a different error)
The part in the CopyTask should also be copied to the maintable beta branch. The rest is already there.